Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(component): init app sidebar #2135

Merged
merged 46 commits into from
Apr 27, 2023
Merged

feat(component): init app sidebar #2135

merged 46 commits into from
Apr 27, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

@himself65 himself65 temporarily deployed to development April 25, 2023 21:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:29 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 27, 2023 7:26pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 7:26pm

@himself65 himself65 changed the title Himself65/sidebar feat(component): init app sidebar Apr 25, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e97c009
Status: ✅  Deploy successful!
Preview URL: https://6f1610b8.affine.pages.dev
Branch Preview URL: https://himself65-sidebar.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development April 25, 2023 21:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:32 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 86.45% and project coverage change: -0.08 ⚠️

Comparison is base (606f665) 70.54% compared to head (e97c009) 70.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2135      +/-   ##
==========================================
- Coverage   70.54%   70.46%   -0.08%     
==========================================
  Files         301      304       +3     
  Lines        5996     5997       +1     
  Branches     1070     1066       -4     
==========================================
- Hits         4230     4226       -4     
- Misses       1556     1565       +9     
+ Partials      210      206       -4     
Flag Coverage Δ
e2etest 67.29% <85.71%> (-0.20%) ⬇️
server-test 90.78% <ø> (ø)
storybook-test 49.64% <54.90%> (+0.62%) ⬆️
unittest 35.53% <30.64%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/blocksuite/workspace-header/styles.ts 92.00% <ø> (+3.53%) ⬆️
.../src/components/pure/workspace-slider-bar/style.ts 90.00% <ø> (-4.45%) ⬇️
apps/web/src/layouts/workspace-layout.tsx 86.16% <ø> (-1.55%) ⬇️
packages/component/src/ui/button/styles.ts 75.60% <ø> (ø)
...web/src/components/affine/sidebar-switch/index.tsx 92.00% <66.66%> (-4.00%) ⬇️
...ges/component/src/components/app-sidebar/index.tsx 70.58% <70.58%> (ø)
apps/web/src/components/root-app-sidebar/index.tsx 83.33% <83.33%> (ø)
.../components/app-sidebar/resize-indicator/index.tsx 90.62% <90.62%> (ø)
apps/web/src/atoms/first-load.ts 100.00% <100.00%> (ø)
.../components/blocksuite/workspace-header/header.tsx 96.96% <100.00%> (-0.18%) ⬇️
... and 4 more

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@perfsee
Copy link

perfsee bot commented Apr 25, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …elf65/sidebar                 +/- ##
===================================================================
< Bundle              4.27 MB        4.28 MB      +15 kB(+0.35%)   
< Initial JS          1.75 MB        1.75 MB    +1.85 kB(+0.11%)   
< Initial CSS         13.2 kB        16.5 kB    +3.3 kB(+25.12%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
< Packages                150            151                  +1   
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …elf65/sidebar                 +/- ##
===================================================================
< Bundle              4.16 MB        4.18 MB      +15 kB(+0.36%)   
< Initial JS          1.65 MB        1.65 MB    +1.85 kB(+0.11%)   
< Initial CSS         13.2 kB        16.5 kB    +3.3 kB(+25.12%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
< Packages                150            151                  +1   
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …elf65/sidebar                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@himself65 himself65 temporarily deployed to development April 25, 2023 21:35 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:38 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:38 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:38 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 21:38 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:53 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:58 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 19:14 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 27, 2023 19:23 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 27, 2023 19:26 Inactive
@himself65 himself65 merged commit c1a65b6 into master Apr 27, 2023
@himself65 himself65 deleted the himself65/sidebar branch April 27, 2023 21:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant