refactor: clean all pages component #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with
|
| Latest commit: |
3b28219
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3dd3e056.affine.pages.dev |
| Branch Preview URL: | https://refactor-all-page.affine.pages.dev |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2176 +/- ##
==========================================
+ Coverage 69.70% 70.35% +0.64%
==========================================
Files 310 308 -2
Lines 6738 6766 +28
Branches 1105 1095 -10
==========================================
+ Hits 4697 4760 +63
+ Misses 1841 1809 -32
+ Partials 200 197 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master …ctor/all-page +/- ##
===================================================================
< Bundle 3.11 MB 3.12 MB +6.59 kB(+0.21%)
> Initial JS 1.86 MB 1.86 MB -3.69 kB(-0.20%)
> Initial CSS 16.8 kB 16.7 kB -2 B(-0.01%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 41 43 +2
< Chunks 39 41 +2
= Packages 132 132
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master …ctor/all-page +/- ##
===================================================================
< Bundle 3 MB 3 MB +6.52 kB(+0.22%)
> Initial JS 1.75 MB 1.74 MB -3.77 kB(-0.22%)
> Initial CSS 16.8 kB 16.7 kB -2 B(-0.01%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 39 41 +2
< Chunks 37 39 +2
= Packages 132 132
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master …ctor/all-page +/- ##
===================================================================
= Bundle 16.6 kB 16.6 kB
= Initial JS 16.6 kB 16.6 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
himself65
reviewed
May 4, 2023
apps/web/src/components/blocksuite/block-suite-page-list/index.tsx
Outdated
Show resolved
Hide resolved
# Conflicts: # apps/web/src/components/blocksuite/block-suite-page-list/page-list/DateCell.tsx
himself65
approved these changes
May 5, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the all pages to the
@affine/componentScreen.Recording.2023-05-03.at.6.20.44.PM.mov