Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(electron): enable disable cloud alert #2184

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Apr 28, 2023

Fixes: #2044

@himself65 himself65 requested a review from JimmFly April 28, 2023 06:12
@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
affine-preview 🔄 Building (Inspect) Apr 28, 2023 6:12am
affine-storybook 🔄 Building (Inspect) Apr 28, 2023 6:12am

@himself65 himself65 marked this pull request as ready for review April 28, 2023 06:12
@himself65 himself65 temporarily deployed to development April 28, 2023 06:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:15 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: -21.04 ⚠️

Comparison is base (70fbbb3) 69.34% compared to head (09c563b) 48.30%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2184       +/-   ##
===========================================
- Coverage   69.34%   48.30%   -21.04%     
===========================================
  Files         311      243       -68     
  Lines        6612     5310     -1302     
  Branches     1084      906      -178     
===========================================
- Hits         4585     2565     -2020     
- Misses       1817     2644      +827     
+ Partials      210      101      -109     
Flag Coverage Δ
e2etest ?
server-test 73.14% <ø> (ø)
storybook-test 49.55% <ø> (ø)
unittest 35.50% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/affine/tmp-disable-affine-cloud-modal/index.tsx 25.00% <ø> (ø)
apps/web/src/components/pure/footer/index.tsx 11.76% <0.00%> (-50.74%) ⬇️
apps/web/src/atoms/index.ts 72.50% <100.00%> (-12.12%) ⬇️

... and 209 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development April 28, 2023 06:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:17 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:17 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:17 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 09c563b
Status: ✅  Deploy successful!
Preview URL: https://b5596bd6.affine.pages.dev
Branch Preview URL: https://himself65-0428-cloud.affine.pages.dev

View logs

@himself65 himself65 enabled auto-merge (squash) April 28, 2023 06:22
@himself65 himself65 temporarily deployed to development April 28, 2023 06:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:23 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 06:23 — with GitHub Actions Inactive
@himself65 himself65 merged commit 73d5b20 into master Apr 28, 2023
@himself65 himself65 deleted the himself65/0428-cloud branch April 28, 2023 06:26
@vercel vercel bot temporarily deployed to Preview – affine-preview April 28, 2023 07:05 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 28, 2023 07:09 Inactive
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Client without Cloud service​
2 participants