feat(component): support image preview by double click #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2198 +/- ##
==========================================
- Coverage 71.78% 71.47% -0.32%
==========================================
Files 296 298 +2
Lines 6593 6650 +57
Branches 1068 1078 +10
==========================================
+ Hits 4733 4753 +20
- Misses 1663 1698 +35
- Partials 197 199 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master …image-preview +/- ##
===================================================================
< Bundle 3.11 MB 3.14 MB +33.7 kB(+1.09%)
< Initial JS 1.86 MB 1.87 MB +8.24 kB(+0.44%)
< Initial CSS 16.8 kB 18.8 kB +2.06 kB(+12.29%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 41 47 +6
< Chunks 39 43 +4
< Packages 132 134 +2
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master …image-preview +/- ##
===================================================================
< Bundle 3 MB 3.02 MB +24.3 kB(+0.81%)
> Initial JS 1.75 MB 1.75 MB -1.17 kB(-0.07%)
< Initial CSS 16.8 kB 18.8 kB +2.06 kB(+12.29%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 39 45 +6
< Chunks 37 41 +4
< Packages 132 134 +2
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master …image-preview +/- ##
===================================================================
= Bundle 16.6 kB 16.6 kB
= Initial JS 16.6 kB 16.6 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
Deploying with
|
| Latest commit: |
4ad7ac1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8c9cca39.affine.pages.dev |
| Branch Preview URL: | https://himself65-0428-image-preview.affine.pages.dev |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1582