Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: clean all page list #2245

Merged
merged 2 commits into from
May 5, 2023
Merged

chore: clean all page list #2245

merged 2 commits into from
May 5, 2023

Conversation

lawvs
Copy link
Collaborator

@lawvs lawvs commented May 5, 2023

  • Remove unused favorite prop from the Trash view
  • Add more story examples

Screenshot 2023-05-05 at 6 12 07 PM

Screenshot 2023-05-05 at 6 11 59 PM

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 34690af
Status: ✅  Deploy successful!
Preview URL: https://05ad8b42.affine.pages.dev
Branch Preview URL: https://chore-clean-all-page.affine.pages.dev

View logs

@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ❌ Failed (Inspect) May 5, 2023 10:30am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 10:30am

@lawvs lawvs temporarily deployed to development May 5, 2023 10:11 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:11 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:11 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:11 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:11 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:11 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:13 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:15 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:15 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:15 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:15 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 5, 2023 10:15 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (fbbcb4b) 70.44% compared to head (34690af) 70.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
- Coverage   70.44%   70.29%   -0.15%     
==========================================
  Files         308      308              
  Lines        6770     6770              
  Branches     1098     1105       +7     
==========================================
- Hits         4769     4759      -10     
- Misses       1800     1812      +12     
+ Partials      201      199       -2     
Flag Coverage Δ
e2etest 67.35% <ø> (-0.23%) ⬇️
server-test 73.14% <ø> (ø)
storybook-test 54.85% <ø> (ø)
unittest 37.30% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/blocksuite/block-suite-page-list/index.tsx 75.40% <ø> (ø)
...es/component/src/components/page-list/all-page.tsx 77.27% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 5, 2023 10:26 Inactive
@perfsee
Copy link

perfsee bot commented May 5, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …lean-all-page                 +/- ##
===================================================================
< Bundle              3.11 MB        3.13 MB      +16 kB(+0.51%)   
< Initial JS          1.86 MB        1.86 MB    +1.32 kB(+0.07%)   
< Initial CSS         16.8 kB        16.8 kB       +19 B(+0.11%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             45                  +4   
< Chunks                   39             42                  +3   
= Packages                132            132                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …lean-all-page                 +/- ##
===================================================================
< Bundle                 3 MB        3.01 MB    +14.9 kB(+0.50%)   
< Initial JS          1.75 MB        1.75 MB      +212 B(+0.01%)   
< Initial CSS         16.8 kB        16.8 kB       +19 B(+0.11%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             43                  +4   
< Chunks                   37             40                  +3   
= Packages                132            132                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …lean-all-page                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 5, 2023 10:30 Inactive
@lawvs lawvs requested review from himself65 and JimmFly May 5, 2023 13:51
@himself65 himself65 merged commit dbd3249 into master May 5, 2023
@himself65 himself65 deleted the chore/clean-all-page branch May 5, 2023 19:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants