Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: remove @toeverything/theme #2254

Merged
merged 5 commits into from
May 8, 2023
Merged

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented May 8, 2023

@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 3:37am
affine-storybook 🔄 Building (Inspect) May 8, 2023 3:37am

@himself65 himself65 force-pushed the himself65/0507-remove-theme branch from 5044ebb to 2d822ef Compare May 8, 2023 03:28
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b0b83a1
Status: ✅  Deploy successful!
Preview URL: https://a19bf438.affine.pages.dev
Branch Preview URL: https://himself65-0507-remove-theme.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development May 8, 2023 03:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:33 — with GitHub Actions Inactive
@himself65 himself65 enabled auto-merge (squash) May 8, 2023 03:33
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -20.04 ⚠️

Comparison is base (d795fb6) 71.64% compared to head (b0b83a1) 51.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2254       +/-   ##
===========================================
- Coverage   71.64%   51.60%   -20.04%     
===========================================
  Files         298      233       -65     
  Lines        6596     5311     -1285     
  Branches     1073      897      -176     
===========================================
- Hits         4726     2741     -1985     
- Misses       1670     2469      +799     
+ Partials      200      101       -99     
Flag Coverage Δ
e2etest ?
server-test 73.14% <ø> (ø)
storybook-test 55.08% <ø> (ø)
unittest 36.97% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/web/next.config.mjs 33.92% <ø> (ø)

... and 191 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development May 8, 2023 03:35 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 8, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …-remove-theme                 +/- ##
===================================================================
< Bundle              3.11 MB        3.13 MB    +21.5 kB(+0.69%)   
< Initial JS          1.86 MB        1.86 MB      +955 B(+0.05%)   
< Initial CSS         16.8 kB        17.1 kB      +388 B(+2.32%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             45                  +4   
< Chunks                   39             42                  +3   
< Packages                132            133                  +1   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …-remove-theme                 +/- ##
===================================================================
< Bundle                 3 MB        3.01 MB    +12.1 kB(+0.40%)   
> Initial JS          1.75 MB        1.74 MB     -8.4 kB(-0.48%)   
< Initial CSS         16.8 kB        17.1 kB      +388 B(+2.32%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             43                  +4   
< Chunks                   37             40                  +3   
< Packages                132            133                  +1   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …-remove-theme                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@himself65 himself65 temporarily deployed to development May 8, 2023 03:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 8, 2023 03:37 — with GitHub Actions Inactive
@himself65 himself65 merged commit c55bfcc into master May 8, 2023
@himself65 himself65 deleted the himself65/0507-remove-theme branch May 8, 2023 03:41
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 8, 2023 04:06 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 8, 2023 04:10 Inactive
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
app:web docs Improvements or additions to documentation mod:component mod:dev mod:theme
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants