Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: enhance root div styles #2295

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

himself65
Copy link
Contributor

No description provided.

@himself65 himself65 requested a review from pengx17 May 10, 2023 05:06
@himself65 himself65 temporarily deployed to development May 10, 2023 05:06 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 5:14am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 5:14am

@himself65 himself65 temporarily deployed to development May 10, 2023 05:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:08 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 10, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …move-root-div                 +/- ##
===================================================================
< Bundle              3.11 MB        3.16 MB    +48.7 kB(+1.57%)   
< Initial JS          1.86 MB        1.87 MB     +9.8 kB(+0.53%)   
< Initial CSS         16.8 kB        28.2 kB   +11.5 kB(+68.59%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             50                  +9   
< Chunks                   39             43                  +4   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …move-root-div                 +/- ##
===================================================================
< Bundle                 3 MB        3.04 MB    +39.2 kB(+1.31%)   
< Initial JS          1.75 MB        1.75 MB      +252 B(+0.01%)   
< Initial CSS         16.8 kB        28.2 kB   +11.5 kB(+68.59%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             48                  +9   
< Chunks                   37             41                  +4   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …move-root-div                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 10, 2023 05:10 Inactive
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.04 ⚠️

Comparison is base (ef665df) 71.19% compared to head (b5cf1ad) 71.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2295      +/-   ##
==========================================
- Coverage   71.19%   71.16%   -0.04%     
==========================================
  Files         322      322              
  Lines        7134     7130       -4     
  Branches     1126     1128       +2     
==========================================
- Hits         5079     5074       -5     
  Misses       1848     1848              
- Partials      207      208       +1     
Flag Coverage Δ
e2etest 67.82% <41.17%> (-0.16%) ⬇️
server-test 73.14% <ø> (ø)
storybook-test 55.19% <9.09%> (-0.25%) ⬇️
unittest 40.45% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/web/src/layouts/public-workspace-layout.tsx 100.00% <ø> (ø)
apps/web/src/pages/_debug/broadcast.dev.tsx 78.94% <ø> (ø)
apps/web/src/pages/_debug/init-page.dev.tsx 75.00% <ø> (ø)
packages/component/src/styles/mui-theme.ts 57.14% <45.45%> (+3.80%) ⬆️
apps/web/src/layouts/workspace-layout.tsx 88.65% <100.00%> (ø)
...kages/component/src/components/workspace/index.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5cf1ad
Status: ✅  Deploy successful!
Preview URL: https://d4fcd2de.affine.pages.dev
Branch Preview URL: https://himself65-0510-remove-root-d.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development May 10, 2023 05:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 10, 2023 05:12 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 10, 2023 05:14 Inactive
@himself65 himself65 merged commit 752d054 into master May 10, 2023
@himself65 himself65 deleted the himself65/0510-remove-root-div branch May 10, 2023 05:39
himself65 added a commit that referenced this pull request May 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants