Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(electron): use affine native #2329

Merged
merged 2 commits into from
May 17, 2023
Merged

feat(electron): use affine native #2329

merged 2 commits into from
May 17, 2023

Conversation

Brooooooklyn
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 4:26am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 4:26am

@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:10 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:10 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn requested a review from pengx17 May 11, 2023 10:10
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:10 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:10 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:10 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:10 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn requested a review from himself65 May 11, 2023 10:10
@github-actions github-actions bot added app:electron Related to electron app test labels May 11, 2023
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:14 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2bdcc6
Status: ✅  Deploy successful!
Preview URL: https://7f2c63bf.affine.pages.dev
Branch Preview URL: https://use-affine-native.affine.pages.dev

View logs

@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:17 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:17 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:17 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:17 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 11, 2023 10:19 Inactive
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (017b9c8) 72.43% compared to head (e2bdcc6) 72.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2329      +/-   ##
==========================================
+ Coverage   72.43%   72.49%   +0.05%     
==========================================
  Files         332      311      -21     
  Lines        7299     6889     -410     
  Branches     1161     1122      -39     
==========================================
- Hits         5287     4994     -293     
+ Misses       1806     1698     -108     
+ Partials      206      197       -9     
Flag Coverage Δ
e2etest 66.68% <ø> (+0.02%) ⬆️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 47.77% <ø> (+0.06%) ⬆️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 73.12% <ø> (ø)
storybook-test 57.23% <ø> (ø)
unittest 37.41% <ø> (-3.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:22 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:22 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:22 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:22 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:22 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:22 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn added this to the AFFiNE 0.6 milestone May 11, 2023
@Brooooooklyn Brooooooklyn temporarily deployed to development May 11, 2023 10:23 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:04 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:04 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:04 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:04 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:04 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 17, 2023 04:07 Inactive
pengx17
pengx17 previously approved these changes May 17, 2023
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:18 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:18 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:18 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:18 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:18 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:21 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 17, 2023 04:22 Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:24 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:24 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:24 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:24 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:24 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:24 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:24 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 04:24 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 17, 2023 04:26 Inactive
@Brooooooklyn Brooooooklyn requested a review from pengx17 May 17, 2023 04:36
@Brooooooklyn Brooooooklyn merged commit 93116c2 into master May 17, 2023
@Brooooooklyn Brooooooklyn deleted the use-affine-native branch May 17, 2023 04:36
Brooooooklyn added a commit that referenced this pull request May 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants