Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: some style updates #2348

Merged
merged 13 commits into from
May 15, 2023
Merged

fix: some style updates #2348

merged 13 commits into from
May 15, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 12, 2023

fix #2350
fix #2345

@codesandbox
Copy link

codesandbox bot commented May 12, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:05 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:05 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 1:42am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 1:42am

@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:05 — with GitHub Actions Inactive
@pengx17 pengx17 requested a review from himself65 May 12, 2023 08:05
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:05 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:05 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:05 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:08 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 12, 2023 08:09 Inactive
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 90.90% and no project coverage change.

Comparison is base (05d8821) 72.54% compared to head (7a34672) 72.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2348   +/-   ##
=======================================
  Coverage   72.54%   72.54%           
=======================================
  Files         329      328    -1     
  Lines        7185     7194    +9     
  Branches     1126     1128    +2     
=======================================
+ Hits         5212     5219    +7     
- Misses       1769     1772    +3     
+ Partials      204      203    -1     
Flag Coverage Δ
e2etest 67.01% <90.00%> (+0.02%) ⬆️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 47.80% <80.00%> (-0.03%) ⬇️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 56.10% <100.00%> (+0.45%) ⬆️
unittest 40.80% <15.38%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/blocksuite/workspace-header/styles.css.ts 100.00% <ø> (ø)
apps/web/src/layouts/workspace-layout.tsx 90.20% <ø> (+0.62%) ⬆️
.../component/src/components/app-sidebar/index.css.ts 100.00% <ø> (ø)
.../src/components/app-sidebar/menu-item/index.css.ts 100.00% <ø> (ø)
...onents/app-sidebar/sidebar-containers/index.css.ts 100.00% <ø> (ø)
...kages/component/src/components/workspace/index.tsx 100.00% <ø> (ø)
apps/web/src/components/root-app-sidebar/index.tsx 84.84% <75.00%> (-3.62%) ⬇️
.../components/blocksuite/workspace-header/header.tsx 85.36% <100.00%> (+0.36%) ⬆️
...omponent/src/components/app-sidebar/index.jotai.ts 60.00% <100.00%> (+2.85%) ⬆️
...ges/component/src/components/app-sidebar/index.tsx 97.05% <100.00%> (+0.90%) ⬆️
... and 2 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7a34672
Status: ✅  Deploy successful!
Preview URL: https://80add0d1.affine.pages.dev
Branch Preview URL: https://0512-fix-styles-update.affine.pages.dev

View logs

@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:11 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 12, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …styles-update                 +/- ##
===================================================================
< Bundle              3.11 MB        3.23 MB     +119 kB(+3.82%)   
< Initial JS          1.86 MB        2.04 MB     +182 kB(+9.79%)   
< Initial CSS         16.8 kB        30.5 kB   +13.7 kB(+81.83%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             47                  +6   
< Chunks                   39             41                  +2   
< Packages                132            140                  +8   
< Duplicates                3              4                  +1   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …styles-update                 +/- ##
===================================================================
< Bundle                 3 MB        3.11 MB     +109 kB(+3.65%)   
< Initial JS          1.75 MB        1.92 MB     +173 kB(+9.88%)   
< Initial CSS         16.8 kB        30.5 kB   +13.7 kB(+81.83%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             45                  +6   
< Chunks                   37             39                  +2   
< Packages                132            140                  +8   
< Duplicates                3              4                  +1   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …styles-update                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 12, 2023 08:13 Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 12, 2023 08:18 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 14, 2023 08:42 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 14, 2023 08:46 Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:34 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:34 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:34 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:34 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:34 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:34 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:36 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 15, 2023 01:38 Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 15, 2023 01:38 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 15, 2023 01:42 Inactive
@himself65 himself65 disabled auto-merge May 15, 2023 04:57
@himself65 himself65 enabled auto-merge (squash) May 15, 2023 04:57
@himself65 himself65 merged commit 183611a into master May 15, 2023
@himself65 himself65 deleted the 0512/fix/styles-update branch May 15, 2023 04:58
himself65 pushed a commit that referenced this pull request May 15, 2023
Brooooooklyn pushed a commit that referenced this pull request May 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Sidebar expand/collapse​ shortcut not working in desktop app Dark mode sidebar UI issues
2 participants