Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add animation for tour modal #2365

Merged
merged 1 commit into from
May 15, 2023
Merged

chore: add animation for tour modal #2365

merged 1 commit into from
May 15, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 15, 2023

Close #2039

@codesandbox
Copy link

codesandbox bot commented May 15, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 8:38am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 8:38am

@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:34 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 15, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …add-animation                 +/- ##
===================================================================
< Bundle              3.11 MB        3.23 MB     +123 kB(+3.95%)   
< Initial JS          1.86 MB        2.05 MB     +184 kB(+9.91%)   
< Initial CSS         16.8 kB        30.5 kB   +13.7 kB(+81.83%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             47                  +6   
< Chunks                   39             41                  +2   
< Packages                132            139                  +7   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …add-animation                 +/- ##
===================================================================
< Bundle                 3 MB        3.11 MB     +113 kB(+3.78%)   
< Initial JS          1.75 MB        1.92 MB    +175 kB(+10.01%)   
< Initial CSS         16.8 kB        30.5 kB   +13.7 kB(+81.83%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             45                  +6   
< Chunks                   37             39                  +2   
< Packages                132            139                  +7   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …add-animation                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 15, 2023 08:34 Inactive
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -0.01 ⚠️

Comparison is base (2c4db4f) 72.37% compared to head (f401402) 72.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   72.37%   72.36%   -0.01%     
==========================================
  Files         329      329              
  Lines        7239     7240       +1     
  Branches     1135     1137       +2     
==========================================
  Hits         5239     5239              
- Misses       1793     1794       +1     
  Partials      207      207              
Flag Coverage Δ
e2etest 66.88% <ø> (ø)
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 47.81% <83.33%> (-0.04%) ⬇️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 55.92% <66.66%> (-0.18%) ⬇️
unittest 40.80% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...component/src/components/tour-modal/tour-modal.tsx 61.11% <71.42%> (+2.28%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f401402
Status: ✅  Deploy successful!
Preview URL: https://594ea017.affine.pages.dev
Branch Preview URL: https://chore-add-animation.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 08:37 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 15, 2023 08:38 Inactive
@lawvs lawvs merged commit 0bfcab4 into master May 15, 2023
@lawvs lawvs deleted the chore/add-animation branch May 15, 2023 08:48
himself65 pushed a commit that referenced this pull request May 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Onboarding carousel
2 participants