Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: remove favorite page #2372

Merged
merged 5 commits into from
May 15, 2023
Merged

chore: remove favorite page #2372

merged 5 commits into from
May 15, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 15, 2023

Close #2367

@codesandbox
Copy link

codesandbox bot commented May 15, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 1:04pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 1:04pm

@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:07 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 15, 2023 10:10 Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:11 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 15, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e22081
Status: ✅  Deploy successful!
Preview URL: https://d94fbe55.affine.pages.dev
Branch Preview URL: https://chore-remove-favorite-item.affine.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (0bfcab4) 72.36% compared to head (8e22081) 72.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2372      +/-   ##
==========================================
+ Coverage   72.36%   72.39%   +0.03%     
==========================================
  Files         329      329              
  Lines        7240     7234       -6     
  Branches     1137     1136       -1     
==========================================
- Hits         5239     5237       -2     
+ Misses       1793     1789       -4     
  Partials      208      208              
Flag Coverage Δ
e2etest 66.93% <ø> (+0.15%) ⬆️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 47.93% <ø> (+0.05%) ⬆️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 56.14% <ø> (ø)
unittest 40.81% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/blocksuite/block-suite-page-list/index.tsx 74.13% <ø> (+2.00%) ⬆️
...b/src/components/pure/quick-search-modal/config.ts 100.00% <ø> (ø)
apps/web/src/components/root-app-sidebar/index.tsx 81.57% <ø> (ø)
apps/web/src/shared/index.ts 75.00% <ø> (+1.31%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 15, 2023 10:15 Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:24 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 15, 2023 10:24 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 15, 2023 10:27 Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 10:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:52 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:52 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:52 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:52 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:52 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:54 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:55 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:55 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:55 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:55 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:55 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:55 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 12:58 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 15, 2023 13:00 Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 13:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 13:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 13:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 13:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 13:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 13:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 13:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 15, 2023 13:00 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 15, 2023 13:04 Inactive
@himself65 himself65 merged commit 0c561da into master May 15, 2023
@himself65 himself65 deleted the chore/remove-favorite-item branch May 15, 2023 15:41
himself65 pushed a commit that referenced this pull request May 15, 2023
Brooooooklyn pushed a commit that referenced this pull request May 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Favorites need to be removed from the Quick search
3 participants