Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add responsive styles for workspace card #2390

Merged
merged 1 commit into from
May 16, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 16, 2023

Close #2384

2023-05-16.14.50.23.mov

@codesandbox
Copy link

codesandbox bot commented May 16, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 6:57am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 6:57am

@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:51 — with GitHub Actions Inactive
@JimmFly JimmFly requested a review from pengx17 May 16, 2023 06:52
@vercel vercel bot temporarily deployed to Preview – affine-preview May 16, 2023 06:53 Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:53 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 16, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …ponsive-style                 +/- ##
===================================================================
< Bundle              3.11 MB        3.25 MB     +137 kB(+4.41%)   
< Initial JS          1.86 MB        2.06 MB    +199 kB(+10.69%)   
< Initial CSS         16.8 kB        30.5 kB   +13.7 kB(+81.83%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             47                  +6   
< Chunks                   39             40                  +1   
< Packages                132            139                  +7   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …ponsive-style                 +/- ##
===================================================================
< Bundle                 3 MB        3.12 MB     +128 kB(+4.26%)   
< Initial JS          1.75 MB        1.94 MB    +190 kB(+10.84%)   
< Initial CSS         16.8 kB        30.5 kB   +13.7 kB(+81.83%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             45                  +6   
< Chunks                   37             38                  +1   
< Packages                132            139                  +7   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …ponsive-style                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (ffd5ae5) 72.26% compared to head (61979c5) 72.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
+ Coverage   72.26%   72.27%   +0.01%     
==========================================
  Files         329      329              
  Lines        7257     7257              
  Branches     1154     1154              
==========================================
+ Hits         5244     5245       +1     
+ Misses       1807     1806       -1     
  Partials      206      206              
Flag Coverage Δ
e2etest 66.63% <ø> (+0.18%) ⬆️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 47.48% <ø> (+0.06%) ⬆️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 56.55% <ø> (ø)
unittest 40.64% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../component/src/components/workspace-card/styles.ts 91.66% <ø> (ø)
.../component/src/components/workspace-list/index.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 61979c5
Status: ✅  Deploy successful!
Preview URL: https://4d911428.affine.pages.dev
Branch Preview URL: https://chore-add-reponsive-style.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:57 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:57 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:57 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:57 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:57 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:57 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:57 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 16, 2023 06:57 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 16, 2023 06:57 Inactive
@JimmFly JimmFly enabled auto-merge (squash) May 16, 2023 06:58
@@ -61,6 +61,9 @@ export const StyledCard = styled('div')<{
pointerEvents: 'auto',
},
},
'@media (max-width: 720px)': {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can still use something like [breakpoints.down('sm', true)]

@JimmFly JimmFly merged commit 7e457f7 into master May 16, 2023
@JimmFly JimmFly deleted the chore/add-reponsive-style branch May 16, 2023 08:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

The popup window of My Workspaces doesn't perform as expected in narrow mode
2 participants