Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: disable confused storybook backgrounds addon #2395

Merged
merged 1 commit into from
May 16, 2023

Conversation

lawvs
Copy link
Collaborator

@lawvs lawvs commented May 16, 2023

@codesandbox
Copy link

codesandbox bot commented May 16, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 16, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3597ecb
Status: ✅  Deploy successful!
Preview URL: https://c3f6348b.affine.pages.dev
Branch Preview URL: https://fix-disable-storybook-backgr.affine.pages.dev

View logs

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 8:55am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 8:55am

@lawvs lawvs temporarily deployed to development May 16, 2023 08:47 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:47 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:47 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:47 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:47 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:47 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:50 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 16, 2023 08:51 Inactive
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (68b4f79) 72.25% compared to head (3597ecb) 72.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2395      +/-   ##
==========================================
- Coverage   72.25%   72.24%   -0.01%     
==========================================
  Files         329      329              
  Lines        7256     7257       +1     
  Branches     1154     1154              
==========================================
  Hits         5243     5243              
  Misses       1808     1808              
- Partials      205      206       +1     
Flag Coverage Δ
e2etest 66.52% <ø> (-0.04%) ⬇️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 47.44% <ø> (+0.01%) ⬆️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 56.55% <ø> (+0.20%) ⬆️
unittest 40.64% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lawvs lawvs temporarily deployed to development May 16, 2023 08:53 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:53 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:53 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:53 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:53 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:53 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:53 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 16, 2023 08:53 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 16, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …ok-background                 +/- ##
===================================================================
< Bundle              3.11 MB        3.23 MB     +120 kB(+3.85%)   
< Initial JS          1.86 MB        2.04 MB     +182 kB(+9.76%)   
< Initial CSS         16.8 kB        30.5 kB   +13.7 kB(+81.83%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             46                  +5   
< Chunks                   39             40                  +1   
< Packages                132            139                  +7   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …ok-background                 +/- ##
===================================================================
< Bundle                 3 MB        3.11 MB     +110 kB(+3.68%)   
< Initial JS          1.75 MB        1.92 MB     +172 kB(+9.85%)   
< Initial CSS         16.8 kB        30.5 kB   +13.7 kB(+81.83%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             44                  +5   
< Chunks                   37             38                  +1   
< Packages                132            139                  +7   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …ok-background                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 16, 2023 08:55 Inactive
@lawvs lawvs merged commit a8b8986 into master May 16, 2023
@lawvs lawvs deleted the fix/disable-storybook-background branch May 16, 2023 09:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants