Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: update button enhancements #2401

Merged
merged 10 commits into from
May 17, 2023
Merged

feat: update button enhancements #2401

merged 10 commits into from
May 17, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 16, 2023 •
edited
Loading

fix #1594 #1572 #2360

New updater logic

  1. Check for new updates every certain period of time (10 minutes), or check for updates through menu->help.
  2. If there is a new version available, it will automatically start downloading and display the download progress here.
  3. After the download is complete, a prompt will appear saying "update available". Clicking on it will restart the application and update it.
  4. When entering the new version, if it is found that the user has not viewed the update log for this version, "what's new" will be displayed.

For Windows/Linux, steps 1 and 4 are consistent except that they directly display "Open download page".

Added check for updates item under help menu category.

  • when you never open or dismiss a changelog for current version
    image

  • when the new version is ready
    image

  • when downloading a new version

image

@codesandbox
Copy link

codesandbox bot commented May 16, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@pengx17 pengx17 requested a review from m1911star May 16, 2023 17:19
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:19 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 8:29am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 8:29am

@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:19 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:19 — with GitHub Actions Inactive
@pengx17 pengx17 requested review from himself65 and removed request for m1911star May 16, 2023 17:19
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:19 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:19 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:19 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:21 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 16, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 261035f
Status: ✅  Deploy successful!
Preview URL: https://9825db3c.affine.pages.dev
Branch Preview URL: https://0517-feat-updater-button.affine.pages.dev

View logs

@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 16, 2023 17:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:08 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:11 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:15 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 08:17 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 17, 2023 08:25 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 17, 2023 08:29 Inactive
@pengx17 pengx17 merged commit 2e0ccb5 into master May 17, 2023
@pengx17 pengx17 deleted the 0517/feat/updater-button branch May 17, 2023 08:58
pengx17 added a commit that referenced this pull request May 17, 2023
@pengx17
feat: update button enhancements (#2401)
edda79c
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@himself65 himself65 himself65 left review comments

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

@m1911star m1911star Awaiting requested review from m1911star

@lawvs lawvs Awaiting requested review from lawvs

@JimmFly JimmFly Awaiting requested review from JimmFly

Assignees

@pengx17 pengx17

Labels
app:electron Related to electron app app:web mod:component mod:i18n Related to i18n
Projects
AFFiNE Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change log support
3 participants
@pengx17 @Brooooooklyn @himself65