fix: infinite reloading #2405
Merged
fix: infinite reloading #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2405 +/- ##
==========================================
+ Coverage 72.43% 72.45% +0.01%
==========================================
Files 332 311 -21
Lines 7299 6886 -413
Branches 1161 1122 -39
==========================================
- Hits 5287 4989 -298
+ Misses 1806 1699 -107
+ Partials 206 198 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Deploying with
|
| Latest commit: |
d8a40ae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8623a6bf.affine.pages.dev |
| Branch Preview URL: | https://himself65-0516-reload.affine.pages.dev |
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master …5/0516-reload +/- ##
===================================================================
< Bundle 3.11 MB 3.25 MB +142 kB(+4.57%)
< Initial JS 1.86 MB 2.06 MB +203 kB(+10.93%)
< Initial CSS 16.8 kB 30.9 kB +14.1 kB(+84.29%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 41 47 +6
< Chunks 39 40 +1
< Packages 132 139 +7
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master …5/0516-reload +/- ##
===================================================================
< Bundle 3 MB 3.13 MB +133 kB(+4.43%)
< Initial JS 1.75 MB 1.94 MB +194 kB(+11.10%)
< Initial CSS 16.8 kB 30.9 kB +14.1 kB(+84.29%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 39 45 +6
< Chunks 37 38 +1
< Packages 132 139 +7
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master …5/0516-reload +/- ##
===================================================================
= Bundle 16.6 kB 16.6 kB
= Initial JS 16.6 kB 16.6 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
himself65
commented
May 17, 2023
| @@ -28,11 +28,7 @@ export const rootWorkspacesMetadataAtom = atomWithStorage< | |||
| ); | |||
|
|
|||
| // two more atoms to store the current workspace and page | |||
| export const rootCurrentWorkspaceIdAtom = atomWithStorage<string | null>( | |||
There was a problem hiding this comment.
storage is unnecessary
pengx17
approved these changes
May 17, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2381