Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: fix electron release build process #2408

Merged
merged 1 commit into from
May 17, 2023

Conversation

Brooooooklyn
Copy link
Member

No description provided.

@codesandbox
Copy link

codesandbox bot commented May 17, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@Brooooooklyn Brooooooklyn requested a review from himself65 May 17, 2023 07:13
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:13 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 9:11am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 9:11am

@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:13 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:13 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:13 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:13 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn requested a review from pengx17 May 17, 2023 07:13
@github-actions github-actions bot added the app:electron Related to electron app label May 17, 2023
himself65
himself65 previously approved these changes May 17, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0c6f9e7
Status: ✅  Deploy successful!
Preview URL: https://9e4821a6.affine.pages.dev
Branch Preview URL: https://fix-electron-build-process.affine.pages.dev

View logs

@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:15 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:15 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:15 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:15 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 07:15 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2629d39) 72.43% compared to head (0c6f9e7) 72.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2408   +/-   ##
=======================================
  Coverage   72.43%   72.44%           
=======================================
  Files         311      312    +1     
  Lines        6886     6892    +6     
  Branches     1122     1122           
=======================================
+ Hits         4988     4993    +5     
- Misses       1699     1701    +2     
+ Partials      199      198    -1     
Flag Coverage Δ
e2etest 66.47% <ø> (+0.06%) ⬆️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 47.83% <ø> (+0.04%) ⬆️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 73.12% <ø> (ø)
storybook-test 57.27% <ø> (+0.03%) ⬆️
unittest 37.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 07:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 07:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 07:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 07:18 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:19 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 07:19 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 17, 2023 08:41 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 17, 2023 08:45 Inactive
@Brooooooklyn Brooooooklyn force-pushed the fix-electron-build-process branch from 5696a4e to 0c6f9e7 Compare May 17, 2023 08:51
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:51 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:51 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:51 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:51 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:51 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:51 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:53 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:54 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:54 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:54 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:54 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:57 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:57 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:57 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:57 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:57 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:57 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:57 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 17, 2023 08:57 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 17, 2023 09:06 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 17, 2023 09:11 Inactive
@Brooooooklyn Brooooooklyn merged commit 1350633 into master May 17, 2023
@Brooooooklyn Brooooooklyn deleted the fix-electron-build-process branch May 17, 2023 09:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants