Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: remove unused code #2425

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

himself65
Copy link
Contributor

No description provided.

@codesandbox
Copy link

codesandbox bot commented May 17, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 11:08pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 11:08pm

@himself65 himself65 temporarily deployed to development May 17, 2023 22:58 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:58 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:58 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:58 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:58 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 🎉

Comparison is base (6c31024) 72.23% compared to head (f5a5c76) 72.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2425      +/-   ##
==========================================
+ Coverage   72.23%   72.34%   +0.11%     
==========================================
  Files         313      310       -3     
  Lines        6959     6933      -26     
  Branches     1141     1139       -2     
==========================================
- Hits         5027     5016      -11     
+ Misses       1730     1716      -14     
+ Partials      202      201       -1     
Flag Coverage Δ
e2etest 65.96% <100.00%> (+0.14%) ⬆️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 47.89% <100.00%> (-0.10%) ⬇️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 73.12% <ø> (ø)
storybook-test 55.89% <ø> (+0.54%) ⬆️
unittest 37.23% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/component/src/styles/mui-theme.ts 57.14% <ø> (ø)
apps/web/src/providers/theme-provider.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development May 17, 2023 23:00 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 17, 2023 23:03 Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:03 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 17, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …remove-unused                 +/- ##
===================================================================
< Bundle              3.11 MB        3.27 MB     +157 kB(+5.05%)   
< Initial JS          1.86 MB        2.05 MB    +187 kB(+10.06%)   
< Initial CSS         16.8 kB        32.3 kB   +15.5 kB(+92.72%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             47                  +6   
< Chunks                   39             40                  +1   
< Packages                132            143                 +11   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …remove-unused                 +/- ##
===================================================================
< Bundle                 3 MB        3.14 MB     +148 kB(+4.92%)   
< Initial JS          1.75 MB        1.93 MB    +178 kB(+10.17%)   
< Initial CSS         16.8 kB        32.3 kB   +15.5 kB(+92.72%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             45                  +6   
< Chunks                   37             38                  +1   
< Packages                132            143                 +11   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …remove-unused                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 17, 2023 23:08 Inactive
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f5a5c76
Status:🚫  Build failed.

View logs

@himself65 himself65 merged commit d6b6407 into master May 18, 2023
@himself65 himself65 deleted the himself65/0517-remove-unused branch May 18, 2023 00:15
himself65 added a commit that referenced this pull request May 18, 2023
himself65 added a commit that referenced this pull request May 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant