Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use data-testid #2487

Merged
merged 6 commits into from
May 22, 2023
Merged

fix: use data-testid #2487

merged 6 commits into from
May 22, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

@codesandbox
Copy link

codesandbox bot commented May 22, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 9:38am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 9:38am

@himself65 himself65 temporarily deployed to development May 22, 2023 09:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:03 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86de662
Status: ✅  Deploy successful!
Preview URL: https://b614f255.affine.pages.dev
Branch Preview URL: https://himself65-0522-test-id.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development May 22, 2023 09:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:05 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (f01997f) 73.11% compared to head (86de662) 73.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2487      +/-   ##
==========================================
+ Coverage   73.11%   73.14%   +0.02%     
==========================================
  Files         316      316              
  Lines        6978     6978              
  Branches     1130     1130              
==========================================
+ Hits         5102     5104       +2     
+ Misses       1678     1675       -3     
- Partials      198      199       +1     
Flag Coverage Δ
e2etest 66.89% <ø> (-0.03%) ⬇️
e2etest-ubuntu-latest-x64 47.98% <ø> (+0.08%) ⬆️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 73.12% <ø> (ø)
storybook-test 56.61% <0.00%> (ø)
unittest 37.51% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e-header/header-right-items/editor-option-menu.tsx 66.66% <ø> (ø)
...ponent/src/components/page-list/operation-cell.tsx 50.00% <0.00%> (ø)
...st/operation-menu-items/disable-public-sharing.tsx 70.00% <0.00%> (ø)
...s/page-list/operation-menu-items/move-to-trash.tsx 92.85% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development May 22, 2023 09:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:13 — with GitHub Actions Inactive
# Conflicts:
#	apps/web/src/components/affine/pinboard/pinboard-render/operation-button.tsx
#	apps/web/src/components/blocksuite/workspace-header/header-right-items/editor-option-menu.tsx
@himself65 himself65 temporarily deployed to development May 22, 2023 09:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:17 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 09:19 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented May 22, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …/0522-test-id                 +/- ##
===================================================================
> Bundle              3.31 MB        3.31 MB        -9 B(-0.00%)   
> Initial JS          2.08 MB        2.08 MB        -9 B(-0.00%)   
= Initial CSS         35.4 kB        35.4 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   47             47                       
= Chunks                   40             40                       
= Packages                145            145                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …/0522-test-id                 +/- ##
===================================================================
> Bundle              3.19 MB        3.19 MB        -9 B(-0.00%)   
> Initial JS          1.96 MB        1.96 MB        -9 B(-0.00%)   
= Initial CSS         35.4 kB        35.4 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   45             45                       
= Chunks                   38             38                       
= Packages                145            145                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …/0522-test-id                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 22, 2023 09:33 Inactive
@himself65 himself65 merged commit ef0a20b into master May 22, 2023
@himself65 himself65 deleted the himself65/0522-test-id branch May 22, 2023 09:36
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 22, 2023 09:38 Inactive
himself65 added a commit that referenced this pull request May 25, 2023
himself65 added a commit that referenced this pull request May 25, 2023
himself65 added a commit that referenced this pull request Jun 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant