Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: some keydown handlers not trigger when multiple editors #8114

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix: some keydown handlers not trigger when multiple editors #8114

merged 1 commit into from
Sep 2, 2024

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Sep 2, 2024 •
edited
Loading

Fix: BS-1256

Remove some redundant disposable group, because they have been added once in packages/framework/block-std/src/view/element/block-component.ts bindHotkeys funtion.

@vercel Vercel
Copy link

vercel bot commented Sep 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 10:28am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 10:28am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6ae257e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 2, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. # using this link.

@donteatfriedrice Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @donteatfriedrice and the rest of your teammates on Graphite Graphite

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 2, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6ae257e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@donteatfriedrice donteatfriedrice marked this pull request as ready for review September 2, 2024 09:21
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 2, 2024 •
edited
Loading

Merge activity

@donteatfriedrice
fix: some keydown handlers not trigger when multiple editors (#8114)
6ae257e 
Fix: [BS-1256](https://linear.app/affine-design/issue/BS-1256/split-view-时打开-center-peek-再关闭，无法再激活任意一个-editor，白板快捷键会失效)

Remove some redundant disposable group, because they have been added once in packages/framework/block-std/src/view/element/block-component.ts bindHotkeys funtion.
@donteatfriedrice donteatfriedrice force-pushed the 09-02-fix_some_keydown_handlers_not_trigger_when_multiple_editors branch from 9d6c825 to 6ae257e Compare September 2, 2024 10:25
@graphite-app graphite-app bot merged commit 6ae257e into master Sep 2, 2024
8 checks passed
@graphite-app graphite-app bot deleted the 09-02-fix_some_keydown_handlers_not_trigger_when_multiple_editors branch September 2, 2024 10:37
@L-Sun L-Sun mentioned this pull request Sep 2, 2024
Merged
L-Sun added a commit to toeverything/AFFiNE that referenced this pull request Sep 2, 2024
@L-Sun
chore: bump blocksuite (#8052)
392fef6 
## Features
- toeverything/blocksuite#8115 @EYHN

## Bugfix
- toeverything/blocksuite#8119 @L-Sun
- toeverything/blocksuite#8117 @zzj3720
- toeverything/blocksuite#8114 @donteatfriedrice

## Misc
- toeverything/blocksuite#8106 @fundon
- toeverything/blocksuite#8116 @doodlewind
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

@CatsJuice CatsJuice Awaiting requested review from CatsJuice

@doodlewind doodlewind Awaiting requested review from doodlewind

Assignees
No one assigned
Labels
merge
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donteatfriedrice @Saul-Mirone