Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update origins.js #1808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update origins.js #1808

wants to merge 1 commit into from

Conversation

hamirmahal
Copy link

@hamirmahal hamirmahal commented Aug 6, 2020

Most, but not all, of the websites in origins.js are in alphabetical order if considering the domain name or the company/service's name.

I think I arranged all the ones that weren't so that they are now in order alphabetically by at least one of domain name and company/service name.

🌟 What does this PR do?

Rearrange the websites in origins.js that are neither sorted by domain name nor company/service name so that they are now sorted according to at least one of domain name and company/service name.

🐛 Recommendations for testing

All changes should be tested across Chrome and Firefox.

📝 Links to relevant issues or information

What the Integrations List Looks Like Before This Change

Previous Toggl Integrations List Not Fully Sorted 2020-08-05 220742

Chrome Integration Test

Toggl Integrations Sorted in Chrome 2020-08-05 220742

Firefox Integration Test

Sorted Toggl Integrations Tested in Firefox 2020-08-05 220742

Most, but not all, of the websites in <code>origins.js</code> are in order by website name or company/service name, but there were a few that were neither.

I think I rearranged all of these unsorted websites so that they are now in order at least alphabetically by website name, or company/service name.
@hamirmahal hamirmahal closed this Aug 6, 2020
@hamirmahal hamirmahal deleted the patch-3 branch August 6, 2020 06:07
@hamirmahal hamirmahal restored the patch-3 branch August 6, 2020 06:07
@hamirmahal hamirmahal reopened this Aug 6, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant