-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix: Add header to gitlab.js #2158
base: master
Are you sure you want to change the base?
Conversation
@@ -221,7 +221,8 @@ export default { | |||
}, | |||
'gitlab.com': { | |||
url: '*://*.gitlab.com/*', | |||
name: 'Gitlab' | |||
name: 'Gitlab', | |||
file: 'gitlab.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line was automatically added by update-origins.js script.
seems to me that CI job running update-origins is half-baked, existing integrations were not modified to add the header. also there's nothing documented about format of the header in CONTRIBUTING.md, and the update-origins.js itself has 0 comments about logic or what should it be doing, some obfuscation contest candidate there. |
Should be rather trivial to write a script that:
but given past slow and negative experience with this repo, I would not do that unless someone explicitly asks to do that. also, the error that the script outputs, should guide the user to go to |
Also, CI for update-origins is set up incorrectly. it runs in the context of the contributing user repository: so, it doesn't appear at all under pull request: probably another reason why other integrations lack the header. I just happened to read my email to see the CI failure. |
🌟 What does this PR do?
Fixes error reported by CI:
reverse-engineered update-origins.js to understand what the hell the error means, as there's definitely nothing written about this in docs/CONTRIBUTING.md