Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(asana.js): update project header selector and include it in board view #2294

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

niyiAO
Copy link
Contributor

@niyiAO niyiAO commented Apr 4, 2024

Please remember the Contributing Guidelines ❤️

🌟 What does this PR do?

updates project header selector, should fix the list view project tracking and add project tracking to board view

🐛 Recommendations for testing

All changes should be tested across Chrome and Firefox.

  • open a project in list view
  • make sure toggl account has a project with same name
  • track some time with extension
  • check that the correct project is assigned
  • repeat for board view

📝 Links to relevant issues or information

Closes: #2293

@niyiAO niyiAO self-assigned this Apr 4, 2024
@niyiAO niyiAO requested a review from a team April 4, 2024 14:01
Copy link
Contributor

@with-shrey with-shrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niyiAO niyiAO merged commit 1991d74 into master Apr 16, 2024
1 check passed
@niyiAO niyiAO deleted the 2293/fix-asana-integration branch April 16, 2024 10:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[asana] project and task names are not correctly populated
2 participants