Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(youtrack): Fix YouTrack integration for single issue pages #2330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pkvach
Copy link
Contributor

@pkvach pkvach commented Sep 16, 2024

🌟 What does this PR do?

Fix YouTrack integration for single issue pages: #2319

  • Modified issue ID selector.

Demo after fix

2024-09-23_23-23

🐛 Recommendations for testing

All changes should be tested across Chrome and Firefox.

The Toggl button should be tested on the YouTrack issue page.
I tested the fix on the public JetBrains YouTrack: https://youtrack.jetbrains.com/issues

How to Test

  1. Navigate to a single issue page in YouTrack.
  2. Verify that the Toggl Button appears and functions correctly.
  3. Ensure that the issue ID and description are correctly captured and displayed.

📝 Links to relevant issues or information

Closes #2319

@pkvach pkvach changed the title fix(youtrack): Fix YouTrack issue element selectors fix(youtrack): Fix YouTrack integration for single issue pages Sep 23, 2024
@with-shrey with-shrey requested a review from askides September 25, 2024 12:33
@intence-ch
Copy link

@askides Would be great if this could be approved

@pkvach pkvach force-pushed the 2319/fix-youtrack branch from 8a5d384 to ba2d075 Compare January 24, 2025 08:23
@pkvach pkvach force-pushed the 2319/fix-youtrack branch from ba2d075 to 4fcaaea Compare January 24, 2025 08:26
@askides
Copy link
Contributor

askides commented Feb 3, 2025

Hi @pkvach and @intence-ch.

I merged a fix for this issue here: #2354

This is available on the new extension version v4.7.2.

Could you try to update the extension and check if the issue is solved?

Thanks.

@intence-ch
Copy link

@askides Unfortunately it does not work for me, both on our own hosted youtrack (unsure of the version) and on youtrack.jetbrains.com. Neither has an element matching $(".idLink__ee62").

Comparing our hosted and the public version there seem to be quite a few changes - this page seems to be a moving target. Suggestion to use the title instead? Possibly more stable?

let [,issueTitle, issueId] = document.title.match(/^(.*) : ([A-Z]+-[0-9]+)$/)

@pkvach
Copy link
Contributor Author

pkvach commented Feb 5, 2025

Hi @askides,

Thanks for the update!

I saw the fix in #2354 and tested the issue #2319 after updating to v4.7.2.
Unfortunately, it still seems to persist.

I’ve resolved the conflicts and updated this PR to address it.
Let me know if you need any further changes.

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome extension doesn't includes task number in time entry description
3 participants