fix: Fix update_source semantics and errors #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultSchema object was not being instantiated correctly resulting in AttributeError. Fix the errors and also resolve relationships to easily access source and schema objects. Fix tokern#65
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 82.35% 83.39% +1.04%
==========================================
Files 8 8
Lines 1054 1078 +24
Branches 103 108 +5
==========================================
+ Hits 868 899 +31
+ Misses 156 147 -9
- Partials 30 32 +2
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultSchema object was not being instantiated correctly resulting in
AttributeError. Fix the errors and also resolve relationships to easily
access source and schema objects.
Fix #65