Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Serialize Json<T> to Bytes instead of Vec<u8> in IntoResponse #1178

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Serialize Json<T> to Bytes instead of Vec<u8> in IntoResponse #1178

merged 1 commit into from
Jul 20, 2022

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Jul 20, 2022

This should remove an unnecessary copy of the serialized JSON. Currently we created Full<Bytes> from the Vec<u8> (copying all contents), with this we will create Full<Bytes> from Bytes (no-op).

@jplatte jplatte requested a review from davidpdrsn July 20, 2022 16:22
@jplatte jplatte mentioned this pull request Jul 20, 2022
Closed
@davidpdrsn davidpdrsn enabled auto-merge (squash) July 20, 2022 16:28
@davidpdrsn davidpdrsn merged commit a3cf025 into main Jul 20, 2022
@davidpdrsn davidpdrsn deleted the jplatte/json-buf branch July 20, 2022 16:32
davidpdrsn pushed a commit that referenced this pull request Jul 25, 2022
@jplatte @davidpdrsn
Serialize Json<T> to Bytes instead of Vec<u8> in IntoResponse (#1178)
ab1ccf8
davidpdrsn added a commit that referenced this pull request Jul 25, 2022
@davidpdrsn
axum: Version 0.5.14
017324f 
Backports these PRs to 0.5.x

- #1192
- #1185
- #1178
- #1171
@davidpdrsn davidpdrsn mentioned this pull request Jul 25, 2022
Merged
davidpdrsn added a commit that referenced this pull request Jul 25, 2022
@davidpdrsn
axum: Version 0.5.14 (#1193)
e6a75a2 
Backports these PRs to 0.5.x

- #1192
- #1185
- #1178
- #1171
@ryanfowler ryanfowler mentioned this pull request Jul 26, 2022
Merged
@Geal Geal mentioned this pull request Aug 12, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplatte @davidpdrsn