Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: add warning icon for extractor order #2027

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

azzamsa
Copy link
Contributor

@azzamsa azzamsa commented May 31, 2023

It adds more brevity.

I have discussed about this PR in discord discussion.

image

Fixes #1913

Motivation

As described in issue #1913. Adding (:warning:) will make the point more noticeable and avoid reading missing the important warning.

Solution

Additional warning emoji (:warning:) added to help the reader find the warning faster.

@azzamsa azzamsa marked this pull request as ready for review May 31, 2023 07:22
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidpdrsn davidpdrsn merged commit 8374c3e into tokio-rs:main Jun 5, 2023
@davidpdrsn davidpdrsn mentioned this pull request Jul 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message regarding the order of extractors
2 participants