io: add AsyncReadExt::read_buf
#3003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
commented
Oct 19, 2020
| ready!(Pin::new(me.reader).poll_read(cx, &mut buf)?); | ||
|
|
||
| // Ensure the pointer does not change from under us | ||
| assert_eq!(ptr, buf.filled().as_ptr()); |
There was a problem hiding this comment.
This the right way to ensure safety?
There was a problem hiding this comment.
We used std::ptr::eq elsewhere, but it should be the same.
carllerche
force-pushed
the
bring-back-read-buf
branch
from
5e19213 to
c44c959
Compare
Brings back `read_buf` from 0.2. This will be stabilized as part of 1.0.
carllerche
force-pushed
the
bring-back-read-buf
branch
from
c44c959 to
aceccf9
Compare
Darksonn
added
A-tokio
taiki-e
reviewed
Oct 20, 2020
If this means that bytes v1 will be released before tokio v1, I have no objection to adding these APIs. |
|
@taiki-e we are aiming to release bytes 1.0 w/ tokio 1.0. I would suggest watching the changes on that repo to track the direction. |
Darksonn
approved these changes
Oct 21, 2020
taiki-e
approved these changes
Oct 21, 2020
Co-authored-by: Alice Ryhl <alice@ryhl.io>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back
read_buffrom 0.2. This will be stabilized as part of 1.0.I need to add tests still.