journald: disable default features of tracing-subscriber #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themaxdavitt
changed the title
themaxdavitt
changed the title
|
I noticed that this affects me as well, so I'd be quite interested in seeing this merged and released. |
|
(Going through all open PRs) This one would be an easy one to rebase and get merged. |
hawkw
approved these changes
May 9, 2022
hawkw
pushed a commit
that referenced
this pull request
Jun 6, 2022
## Motivation Closes #1465. ## Solution I'm just disabling the default features of `tracing-journald`'s dependency on `tracing-subscriber`. The original issue talked about the crate's dependencies more broadly but considering that the standard library is already depended upon I didn't think it made sense to change the `tracing-core` dependency's features (which are just `no_std` support).
hawkw
pushed a commit
that referenced
this pull request
Jun 7, 2022
## Motivation Closes #1465. ## Solution I'm just disabling the default features of `tracing-journald`'s dependency on `tracing-subscriber`. The original issue talked about the crate's dependencies more broadly but considering that the standard library is already depended upon I didn't think it made sense to change the `tracing-core` dependency's features (which are just `no_std` support).
hds
added a commit
that referenced
this pull request
Nov 29, 2024
# 0.3.1 (November 29, 2024) [ [crates.io][crate-0.3.1] ] | [ [docs.rs][docs-0.3.1] ] ### Changed - disable default features of tracing-subscriber ([#1476]) - allow custom journal fields ([#2708]) - Bump MSRV to 1.63 ([#2793]) - make level mappings configurable ([#2824]) [#1476]: #1476 [#2708]: #2708 [#2793]: #2793 [#2824]: #2824 [docs-0.3.1]: https://docs.rs/tracing-journald/0.3.1 [crate-0.3.1]: https://crates.io/crates/tracing-journald/0.3.1
hds
added a commit
that referenced
this pull request
Nov 29, 2024
# 0.3.1 (November 29, 2024) [ [crates.io][crate-0.3.1] ] | [ [docs.rs][docs-0.3.1] ] ### Changed - disable default features of tracing-subscriber ([#1476]) - allow custom journal fields ([#2708]) - Bump MSRV to 1.63 ([#2793]) - make level mappings configurable ([#2824]) [#1476]: #1476 [#2708]: #2708 [#2793]: #2793 [#2824]: #2824 [docs-0.3.1]: https://docs.rs/tracing-journald/0.3.1 [crate-0.3.1]: https://crates.io/crates/tracing-journald/0.3.1
hds
added a commit
that referenced
this pull request
Nov 29, 2024
# 0.3.1 (November 29, 2024) [ [crates.io][crate-0.3.1] ] | [ [docs.rs][docs-0.3.1] ] ### Changed - disable default features of tracing-subscriber ([#1476]) - allow custom journal fields ([#2708]) - Bump MSRV to 1.63 ([#2793]) - make level mappings configurable ([#2824]) [#1476]: #1476 [#2708]: #2708 [#2793]: #2793 [#2824]: #2824 [docs-0.3.1]: https://docs.rs/tracing-journald/0.3.1 [crate-0.3.1]: https://crates.io/crates/tracing-journald/0.3.1
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1465.
Solution
I'm just disabling the default features of
tracing-journald's dependency ontracing-subscriber. The original issue talked about the crate's dependencies more broadly but considering that the standard library is already depended upon I didn't think it made sense to change thetracing-coredependency's features (which are justno_stdsupport).