Opentelemetry: Fix example bug of missing root span #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryangarza
approved these changes
May 10, 2022
|
Thanks for the PR! |
hawkw
pushed a commit
that referenced
this pull request
Jun 6, 2022
Co-authored-by: Bryan Garza <1396101+bryangarza@users.noreply.github.com>
hawkw
pushed a commit
that referenced
this pull request
Jun 7, 2022
Co-authored-by: Bryan Garza <1396101+bryangarza@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1743
Fix the opentelemetry example's bug of missing root span.
Motivation
The result of example should not miss root span.
Solution
The
rootspan should be dropped beforeopentelemetry providershutdown.p.s. I'm sorry that I'm not good at English, so please be relaxed to edit.