Use ManuallyDrop instead of mem::forget #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
hawkw,
davidbarsky and
a team
as code owners
|
uh oh. i'm headed to the airport for a vacation, but I started the CI for this. i'm guessing Miri would've caught this? |
|
no idea! |
hawkw
approved these changes
Oct 18, 2023
hawkw
pushed a commit
that referenced
this pull request
Oct 19, 2023
The current code is UB and LLVM could choose to reuse the stack slot causing a UAF. ## Motivation UB is bad. ## Solution Don't do that.
hawkw
added a commit
that referenced
this pull request
Oct 19, 2023
# 0.1.40 This release fixes a potential stack use-after-free in the `Instrument::into_inner` method. Only uses of this method are affected by this bug. ### Fixed - Use `mem::ManuallyDrop` instead of `mem::forget` in `Instrument::into_inner` (#2765) [#2765]: #2765 Thanks to @cramertj and @Manishearth for finding and fixing this issue!
|
Wait, this is weird...that |
|
Gotta love functions that include a Safety section which aren't marked as |
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
Nov 21, 2023
The current code is UB and LLVM could choose to reuse the stack slot causing a UAF. ## Motivation UB is bad. ## Solution Don't do that.
24 tasks
4 tasks
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.1.40 This release fixes a potential stack use-after-free in the `Instrument::into_inner` method. Only uses of this method are affected by this bug. ### Fixed - Use `mem::ManuallyDrop` instead of `mem::forget` in `Instrument::into_inner` (tokio-rs#2765) [tokio-rs#2765]: tokio-rs#2765 Thanks to @cramertj and @Manishearth for finding and fixing this issue!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is UB and LLVM could choose to reuse the stack slot causing a UAF.
Motivation
UB is bad.
Solution
Don't do that.