-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
subscriber: skip padding when skipping log.*
fields in DefaultVisitor
#2980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about moving the check for log metadata to before the match statement?
03a6f54
to
b8f6828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your change!
log.*
fields in DefaultVisitor
same here |
Hi @hds, it's been a while since |
Motivation
Closes #2979.
The current behaviour of
DefaultVisitor
is that it will write padding even if it is going to skip writing a value, which results in extraneous padding being added when values are skipped by thetracing-log
integration.Solution
With this change,
DefaultVisitor
will only insert padding if it is actually going to write a value.