core: replace Once::data inner type to MaybeUninit #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a TODO suggesting we should use mem::uninitialized to replace Option, but since the suggested function is deprecated, we should use MaybeUninit instead. This PR makes exactly that change. Signed-off-by: Jay Wang <xdddxyyyxzzz123@gmail.com>
|
Can't we just switch directly to |
On a closer look, I think we can't use |
|
@iamlockon this code doesn't compile ( |
this fixes the PR comment: tokio-rs#3206 (comment)
|
@Jesse-Bakker Thanks for catching that! I missed it because I only tried cargo build locally.. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a TODO suggesting we should use mem::uninitialized to replace Option, but since the suggested function is deprecated, we should use MaybeUninit instead. This PR makes exactly that change.
Motivation
I am learning tracing source code, and spotted this TODO and feel I might be able to help address this one.
Solution
Updated the Once::data inner type from
Option<T>toMaybeUninit<T>.