Removed always exploding/rerolling for highest/lowest values and fixed infinite loops #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e if a condition is specified. Fixed infinite loops that could happen if exploding/reroll conditions included all dice faces.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even If a reroll condition was specified (
4d6r=4), the lowest dice value would always be rerolled. The same thing happens for exploding dice, but with the highest dice value.This pull request changes that to only include highest/lowest value to exploding/rerolling if no condition is specified. This is the way the roll20 dice specification works.
I also added a check to explode/reroll conditions to make sure they don't include all dice faces, preventing an infinite loop (
1d6r<7or1d6!>=1would execute forever)Added tests.