Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Provide the ability to preserve Tor key material across restarts #18

Merged
merged 2 commits into from
Mar 5, 2022
Merged

Provide the ability to preserve Tor key material across restarts #18

merged 2 commits into from
Mar 5, 2022

Conversation

SailReal
Copy link
Contributor

@SailReal SailReal commented Mar 5, 2022

No description provided.

@tomMoulard tomMoulard force-pushed the feature/preserve-keys branch 2 times, most recently from f76b65e to 9961864 Compare March 5, 2022 14:51
@tomMoulard tomMoulard force-pushed the feature/preserve-keys branch from 9961864 to 37e5ee7 Compare March 5, 2022 14:52
@tomMoulard
Copy link
Owner

I've changed a bit your contribution, is it still ok for you like this ?

@tomMoulard tomMoulard added contributor/waiting-for-feedback Waiting for contributor's feedback kind/enhancement New feature or request labels Mar 5, 2022
tomMoulard
tomMoulard approved these changes Mar 5, 2022
View reviewed changes
Copy link
Owner

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

SailReal
SailReal commented Mar 5, 2022
View reviewed changes
Copy link
Contributor Author

@SailReal SailReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM too, thank you, also for fixing the tests, I was not at the pc right now and you were faster, will run them locally next time.

@tomMoulard tomMoulard merged commit f211b1a into tomMoulard:master Mar 5, 2022
@SailReal SailReal deleted the feature/preserve-keys branch March 5, 2022 15:00
@tomMoulard tomMoulard added area/services/tor and removed contributor/waiting-for-feedback Waiting for contributor's feedback labels Jul 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tomMoulard tomMoulard tomMoulard approved these changes

Assignees
No one assigned
Labels
area/services/tor kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SailReal @tomMoulard