Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add ciao #33

Merged
merged 4 commits into from
Nov 18, 2022
Merged

Add ciao #33

merged 4 commits into from
Nov 18, 2022

Conversation

SailReal
Copy link
Contributor

No description provided.

tomMoulard
tomMoulard reviewed Nov 17, 2022
View reviewed changes
Copy link
Owner

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also add a ciao/.gitignore file to exclude ./ciao/db folder to be on git.

ciao/docker-compose.ciao.yml Outdated Show resolved Hide resolved
.env.default Show resolved Hide resolved
ciao/docker-compose.ciao.yml Outdated Show resolved Hide resolved
@tomMoulard tomMoulard added the kind/enhancement New feature or request label Nov 17, 2022
SailReal and others added 2 commits November 17, 2022 20:21
@SailReal @tomMoulard
Apply suggestions from code review
388369b 
Co-authored-by: Tom Moulard <tom@moulard.org>
@SailReal
Add gitignore
8ea3db9
tomMoulard
tomMoulard approved these changes Nov 18, 2022
View reviewed changes
Copy link
Owner

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@tomMoulard tomMoulard merged commit 18738f7 into tomMoulard:master Nov 18, 2022
@SailReal SailReal deleted the feature/add-ciao branch November 18, 2022 08:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tomMoulard tomMoulard tomMoulard approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SailReal @tomMoulard