Add compatibility with new app API request in TrueNAS 24.10 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new attribute names that changes in 24.10, system will show matching attribute names and ignores the other
In TS 24.10, app API request changed from "chart/release" to "app" and minor change in attribute names. This commit check if TrueNAS version is before 24.10 or after, and use the right parameter to request app list and its attributes.
Change default value of "updated_version" from "unknown" to current version.
|
It seems to work fine for me, thank you very much! |
This reverts commit e72d21d.
|
thanks, not sure about using default like that as it may cause infinite crash loop, but we will see. otherwise looks great |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Additional information
Checklist