-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Consider reducing the dependency graph #21
Comments
I have tried to package a fat jar with git-changelog-lib. There might still be a branch with that in the lib. The problem was with JGit. I think it was the dates that became incotrect in generated changelogs. I could not figure oit why. |
I pushed a branch with this here: And a branch using it here: When I do --- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,184 +2,206 @@
Changelog of Git Changelog Gradle plugin.
-## 1.64
+## Unreleased
### No issue
-**Update .travis.yml**
+**Update README to use Plugin DSL**
-[32f936846588f3b](https://github.com/tomasbjerre/git-changelog-gradle-plugin/commit/32f936846588f3b) Tomas Bjerre *2019-08-13 04:35:49*
+[a4cb64c0e4c9184](https://github.com/tomasbjerre/git-changelog-gradle-plugin/commit/a4cb64c0e4c9184) Chad Vincent *1970-01-01 00:00:00* |
Hi @tomasbjerre!
This plugin looks really interesting and I'd like to use it. However, it pulls in too many dependencies, including some dependencies that are known to cause compatibility issues (#18). Therefore I cannot quite recommend your plugin to our projects (although I wish otherwise :-). Can you consider reducing the dependency graph in git-changelog-lib? Try to minimize the incoming dependencies because they are a liability to your customers. Ideally "git-changelog-lib" brings no dependencies.
I tried your plugin in my project and here's the dependency graph (
./gradlew bEnv
):Nice work with this Gradle plugin!
The text was updated successfully, but these errors were encountered: