Remove goto for lua 5.1 compatiblity #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto was introduced in lua 5.2. mpv supports lua 5.1, so user scripts should too.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I prefer the version with
goto, I was recently made aware in one of me PRs for mpv thatgotois not supported in lua 5.1. mpv supports lua 5.1 as minimum version, so user scripts should too.Simply replaced the
gotowith a big if block.While testing this I noticed that the notch at 100 sometimes shows and sometimes disappears depending on the position while dragging (and i confirmed it already did before my change). Must be some floating point thing.