Complete menu colours in terminal look odd

[schivmeister]

Everything looks perfect with this scheme by default, except for the colouring of popups. Here it looks like the colours are inverted. If this is not intentional, then simply use the same colours as the statusline:

--- a/colors/molokai.vim                                                        
+++ b/colors/molokai.vim                                                        
@@ -176,8 +176,8 @@ if &t_Co > 255                                              
    hi Operator        ctermfg=161                                              

    " complete menu                                                             
-   hi Pmenu           ctermfg=81  ctermbg=16                                   
-   hi PmenuSel                    ctermbg=244                                  
+   hi Pmenu           ctermfg=253 ctermbg=238                                  
+   hi PmenuSel        ctermfg=81  ctermbg=16                                   
    hi PmenuSbar                   ctermbg=232                                  
    hi PmenuThumb      ctermfg=81

[tomasr]

Could you share a screenshot of how each of the two versions look for you? I don't use the terminal version much myself, and don't have a test environment handy at the moment....

[schivmeister]

Sure, I should've done that while reporting this. Here it is:

[tomasr]

Wouldn't it make more sense to just change the selected foreground color, rather than invert the entire color selection?

[schivmeister]

Yes, anything like that would work, as long as the contrast is there. The proposed scheme just fits better IMO, consistent with for e.g. the statusline.

I just had the chance to check the GVim colours and there the text is white, so it looks OK. So maybe if you want to keep both GUI and CLI colours in sync then just changing foreground would be fine.