fix #22: 'hi Normal ctermbg=234' sets background=light #26
Conversation
|
@tomasr anything causing hesitation on this? |
|
👍 |
|
seems good, though it's 3 space tabs, not 2. |
|
Oh, right. Happy to correct that if @tomasr gives some indication of intent to merge. BTW, this is a known issue with Vim's color detection, for which a patch was suggested: |
|
That said, I couldn't find any visual reason to use this patch. If I followed the readme and called |
|
what terminal are you using? Did you try running without plugins? I tried with/without this patch in Mac OS Terminal.app, and the result seems to be identical, except The motivation for this patch is that some plugins or autocmds may make decisions based on |
|
gotcha. That makes sense. Thanks for the explanation. |
| ``` | ||
| let g:rehash256 = 1 | ||
| ``` | ||
|
|
||
| Note: when using the console version, add this command after enabling the colorscheme in your .vimrc: | ||
| ``` | ||
| set background=dark |
There was a problem hiding this comment.
not necessary after this patch
|
@tomasr I updated this pull request with a much simpler fix. Care to comment? |
fix #22: 'hi Normal ctermbg=234' sets background=light
ugly hack to prevent background=lightupdate: a redditor suggested a better fix, which is to simply move the
set bgstatement to the bottom of the syntax file. I've updated the pull request.