Make search highlight more visible #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry guys, I've been reluctant to merge changes to the console side as I don't use it, and can't always verify what the end results are. I'm going through all the pending ones now. So do you want this one or the alternative proposed? |
|
I prefer @vellvisher 's suggestion. evindor@8435b84#commitcomment-5984725 |
|
@vellvisher's suggestion seems to be more solid as it's from original monokai, however i really liked the bright orange i made, great visibility. But i guess it's too extreme to be the default one. |
|
OK, done. @evindor submit a patch with a global setting for controlling it as an option, if you want, that way we can have the best of both worlds :) |
pR0Ps
pushed a commit
to pR0Ps/molokai-dark
that referenced
this pull request
Oct 29, 2015
See tomasr#32 (comment) for details
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default one is very hard to notice. I guess i'm not the only one who thinks so.
