-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Changed Error color to #ff3333 red, better visibility #37
base: master
Are you sure you want to change the base?
Conversation
jasonlevinsohn
commented
Jun 5, 2014
- Started using this color and really like it, but the error color when checking validation or syntax is very faint.
- Error's should stand out
- Thought others might share the same sentiment
Can you post a before/after screenshot? |
@jasonlevinsohn Could you also add I would like to see this change merged. The current error color is close to useless. |
@@ -161,7 +161,7 @@ if &t_Co > 255 | |||
hi DiffText ctermbg=102 cterm=bold | |||
|
|||
hi Directory ctermfg=118 cterm=bold | |||
hi Error ctermfg=219 ctermbg=89 | |||
hi Error ctermfg=219 ctermbg=196 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinmk The foreground color I think is fine. I changed the background in the 256-color section to the closest color I could find.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctermfg=219
is a bit muddled, I would vote to just go for a full ctermfg=255
.
@@ -161,7 +161,7 @@ if &t_Co > 255 | |||
hi DiffText ctermbg=102 cterm=bold | |||
|
|||
hi Directory ctermfg=118 cterm=bold | |||
hi Error ctermfg=219 ctermbg=89 | |||
hi Error ctermfg=255 ctermbg=196 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinmk I couldn't get my editor to display in 256 color so I'm not able to test. updated to ctermfg=255
Changed Error color to #ff3333 red, better visibility
Changed Error color to #ff3333 red, better visibility
Changed Error color to #ff3333 red, better visibility