Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Option to disable italicized text #39

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Option to disable italicized text #39

wants to merge 4 commits into from

Conversation

dpy-
Copy link

@dpy- dpy- commented Jul 22, 2014

In some instances, italicized text does not display well in the GUI. This adds an option to disable it.

@justinmk
Copy link
Contributor

Please don't add random ad-hoc options to a colorscheme.

@dpy-
Copy link
Author

dpy- commented Jul 22, 2014

Fair enough, but I don't see any other way to disable italics text in Vim. Also Solarized has this option: https://github.com/altercation/vim-colors-solarized#advanced-configuration

@cowboy
Copy link

cowboy commented Jan 3, 2015

I would love for this to be merged!

cowboy added a commit to cowboy/dotfiles that referenced this pull request Jan 3, 2015
cowboy added a commit to cowboy/dotfiles that referenced this pull request Jan 8, 2015
jesperronn pushed a commit to jesperronn/cowboy-dotfiles that referenced this pull request Jan 21, 2015
edentsai added a commit to edentsai/extended-molokai that referenced this pull request Oct 2, 2015
Option to disable italicized text
edentsai added a commit to edentsai/extended-molokai that referenced this pull request Oct 4, 2015
Option to disable italicized text
edentsai added a commit to edentsai/extended-molokai that referenced this pull request Oct 4, 2015
Option to disable italicized text
@alerque
Copy link

alerque commented Jun 3, 2016

I believe this needs to be merged, far too many people are having to run their own forks to get this to behave itself. Contrary to what @justinmk commented, this isn't a random ad-hoc option either. This color scheme defines a whole bunch of italics which don't work for some fonts and terminals. If this color scheme is going to apply non-color properties it should also provide a way to not apply those and said same properties.

alerque pushed a commit to alerque/que-vim that referenced this pull request Jun 3, 2016
voldikss added a commit to voldikss/dotfiles that referenced this pull request May 1, 2019
@kamaboko123
Copy link

Thank you for good enhancement.
It is very helpful for me.

However, I found issue in README.md.
Could you fix following line?
let g:molokai_italics = 0
I think last s is not needed.
let g:molokai_italic = 0

darrylgit added a commit to darrylgit/dotfiles that referenced this pull request Jun 3, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants