r/build_config: support for updating the name field

Dependent on cvbarros/go-teamcity#82
tombuildsstuff · Apr 24, 2020 · 7ebae88 · 7ebae88
1 parent dd8d2c2
commit 7ebae88
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/teamcity/resource_build_config.go b/teamcity/resource_build_config.go
@@ -67,7 +67,6 @@ func resourceBuildConfig() *schema.Resource {
 			"name": {
 				Type:     schema.TypeString,
 				Required: true,
-				ForceNew: true,
 			},
 			"is_template": {
 				Type:     schema.TypeBool,
@@ -308,6 +307,10 @@ func resourceBuildConfigUpdate(d *schema.ResourceData, meta interface{}) error {
 		return err
 	}
 
+	if d.HasChange("name") {
+		dt.Name = d.Get("name").(string)
+	}
+
 	var changed bool
 	if d.HasChange("sys_params") || d.HasChange("config_params") || d.HasChange("env_params") {
 		log.Printf("[DEBUG] resourceBuildConfigUpdate: change detected for params")

diff --git a/teamcity/resource_build_config_test.go b/teamcity/resource_build_config_test.go
@@ -3,12 +3,13 @@ package teamcity_test
 import (
 	"errors"
 	"fmt"
-	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
-	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 	"regexp"
 	"strings"
 	"testing"
 
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/terraform"
+
 	api "github.com/cvbarros/go-teamcity/teamcity"
 )
 
@@ -195,6 +196,7 @@ func TestAccBuildConfig_UpdateBasic(t *testing.T) {
 				Config: TestAccBuildConfigBasicUpdated,
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckBuildConfigExists(resName, &bc),
+					resource.TestCheckResourceAttr(resName, "name", "build config updated"),
 					resource.TestCheckResourceAttr(resName, "description", "build config test desc updated"),
 				),
 			},
@@ -861,7 +863,7 @@ resource "teamcity_project" "build_config_project_test" {
 }
 
 resource "teamcity_build_config" "build_configuration_test" {
-	name = "build config test"
+	name = "build config updated"
 	project_id = "${teamcity_project.build_config_project_test.id}"
 	description = "build config test desc updated"
 	settings {