Upgrade to Spring boot 3 #50
Conversation
* Use jakarta api instead of javax api * Change the source and target to 1.8 * Fix test cases * Date format changes. Refer: spring-projects/spring-framework#16531 * Documentation changes * Version changes
|
@tomdesair Merge is highly anticipated. Any updates/plans on this topic? |
|
Since this change would prohibit deployment to any pre Jakarta-Servlet 6.0 servlet container, like Tomcat 9, I'd propose a larger bump in version (maybe 1.1). |
|
|
||
| You can add the latest stable version of this library to your application using Maven by adding the following dependency: | ||
|
|
||
| <dependency> | ||
| <groupId>me.desair.tus</groupId> | ||
| <artifactId>tus-java-server</artifactId> | ||
| <version>1.0.0-2.0</version> | ||
| <version>1.0.0-3.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Should the version be 1.0.0-3.0, since this is a breaking change
| <maven.compiler.source>1.7</maven.compiler.source> | ||
| <maven.compiler.target>1.7</maven.compiler.target> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> |
There was a problem hiding this comment.
If we go for the breaking change, then the compiler source and target should be 17?
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Spring test no longer includes spring-web, hence this was externalized
|
Hi @ghoshrahul Could you describe the change required for notnull --> any check. fyi- I also faced the dateformat changes. |
|
Hi @ksvraja , Along with the upgrade to spring boot 3, I have also upgraded mockito framework as well from 2.23.4 to 4.8.1 As per the mockito documentation, the You can read the changes as presented in the source code Date format changes are required, because spring has made changes to the MockHttpServletResponse class, for which the link is shared in the first comment itself. |
|
Thank you @ghoshrahul for all the hard work and apologies for the late reply. I'll merge your changes, give this project's CI/CD a refresh and get a new release out of the door. |
|
Thanks @tomdesair . Looking forward to the next release of the tus-java-server :) |
|
hi, do you have any idea when will the release take place ? I am waiting the 1.0.0-3.0 for a project in springboot 3 |
|
This has now been released to Maven Central as version |
Pull request for this issue