Merge pull request #344 from WilliamBruneau/fix_oneshotserver

Make OneShotServer terminates after client connection ends
tomerfiliba-org · Jul 27, 2019 · 6027430 · 6027430
2 parents d403421 + 3ac1cdc
commit 6027430
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/rpyc/utils/server.py b/rpyc/utils/server.py
@@ -186,7 +186,7 @@ def _authenticate_and_serve_client(self, sock):
                 sock.shutdown(socket.SHUT_RDWR)
             except Exception:
                 pass
-            sock.close()
+            closing(sock)
             self.clients.discard(sock)
 
     def _serve_client(self, sock, credentials):
@@ -286,8 +286,10 @@ class OneShotServer(Server):
     """
 
     def _accept_method(self, sock):
-        with closing(sock):
+        try:
             self._authenticate_and_serve_client(sock)
+        finally:
+            self.close()
 
 
 class ThreadedServer(Server):