Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use up to date toml for serialization #197

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

tommilligan
Copy link
Owner

Closes #196

I was working under a false assumption that because mdbook uses toml 0.5.11 internally, (i.e. the values that is exposes in the public api are toml::Values from 0.5.11), we had to use a matching toml version to perform serde operations on them.

This is not true, so we can upgrade to avoid the known bugs like #196! This would have been great to know about three months ago, but TIL.

@tommilligan tommilligan merged commit a942a80 into main Jun 20, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admonish breaks if on_failure = "bail" is set and [preprocessor.admonish.default] exists in book.toml
1 participant