fix: wasted regexp

tommy-muehle · Jan 11, 2022 · bcb2113 · bcb2113
1 parent f391143
commit bcb2113
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/config/config.go b/config/config.go
@@ -44,35 +44,32 @@ func WithOptions(options ...Option) *Config {
 
 func WithIgnoredFunctions(excludes string) Option {
 	return func(config *Config) {
-		if excludes == "" {
-			return
-		}
-
 		for _, exclude := range strings.Split(excludes, ",") {
+			if exclude == "" {
+				continue
+			}
 			config.IgnoredFunctions = append(config.IgnoredFunctions, regexp.MustCompile(exclude))
 		}
 	}
 }
 
 func WithIgnoredFiles(excludes string) Option {
 	return func(config *Config) {
-		if excludes == "" {
-			return
-		}
-
 		for _, exclude := range strings.Split(excludes, ",") {
+			if exclude == "" {
+				continue
+			}
 			config.IgnoredFiles = append(config.IgnoredFiles, regexp.MustCompile(exclude))
 		}
 	}
 }
 
 func WithIgnoredNumbers(numbers string) Option {
 	return func(config *Config) {
-		if numbers == "" {
-			return
-		}
-
 		for _, number := range strings.Split(numbers, ",") {
+			if number == "" {
+				continue
+			}
 			config.IgnoredNumbers[config.removeDigitSeparator(number)] = struct{}{}
 		}
 	}
@@ -89,6 +86,9 @@ func WithCustomChecks(checks string) Option {
 		}
 
 		for _, name := range strings.Split(checks, ",") {
+			if name == "" {
+				continue
+			}
 			config.Checks[name] = true
 		}
 	}