Skip to content

fix: impl<'a> From<AsciiString> for Cow<'a, AsciiStr> #111

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanikVitek
Copy link

@DanikVitek DanikVitek commented Jan 29, 2025

Fixes #110

Modify the implementation of From<AsciiString> for Cow<'a, AsciiStr>.

  • Change impl From<AsciiString> for Cow<'static, AsciiStr> to impl<'a> From<AsciiString> for Cow<'a, AsciiStr> in src/ascii_string.rs
  • Broaden the conversion abilities by making it generic over any lifetime 'a

For more details, open the Copilot Workspace session.

Fixes tomprogrammer#110

Modify the implementation of `From<AsciiString>` for `Cow<'a, AsciiStr>`.

* Change `impl From<AsciiString> for Cow<'static, AsciiStr>` to `impl<'a> From<AsciiString> for Cow<'a, AsciiStr>` in `src/ascii_string.rs`
* Broaden the conversion abilities by making it generic over any lifetime `'a`

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/tomprogrammer/rust-ascii/issues/110?shareId=XXXX-XXXX-XXXX-XXXX).
@DanikVitek
Copy link
Author

@tomprogrammer

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impl From<AsciiString> for Cow<'static, AsciiStr> could be impl<'a> From<AsciiString> for Cow<'a, AsciiStr>
1 participant