eth_getProof balance and nonce to U256 #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry about this 😞 |
|
No worries! Could you please add a testcase for these large values as well? |
after some real-world testing, we figured balance as well as nonce fields might reach the upper limit of U64. Moving these fields to U256
lightyear15
force-pushed
the
giulio/u256_balance
branch
from
b471377 to
3da6317
Compare
|
Hi @tomusdrw |
|
Perfect, thank you! |
tomusdrw
approved these changes
Nov 30, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after some real-world testing, we figured balance as well as nonce
fields might reach the upper limit of U64.
Moving these fields to U256